mirror of
https://github.com/liyunfan1223/mod-playerbots.git
synced 2026-06-20 23:49:25 +02:00
e7d5eaabac
# Pull Request When integrating latest changes from https://github.com/azerothcore/azerothcore-wotlk into https://github.com/mod-playerbots/azerothcore-wotlk/tree/Playerbot you will face some compiling issues due to refactoring. That PR does not change any of the logic, but implements needed changes to be compatible again --- ## Design Philosophy We prioritize **stability, performance, and predictability** over behavioral realism. Complex player-mimicking logic is intentionally limited due to its negative impact on scalability, maintainability, and long-term robustness. Excessive processing overhead can lead to server hiccups, increased CPU usage, and degraded performance for all participants. Because every action and decision tree is executed **per bot and per trigger**, even small increases in logic complexity can scale poorly and negatively affect both players and world (random) bots. Bots are not expected to behave perfectly, and perfect simulation of human decision-making is not a project goal. Increased behavioral realism often introduces disproportionate cost, reduced predictability, and significantly higher maintenance overhead. Every additional branch of logic increases long-term responsibility. All decision paths must be tested, validated, and maintained continuously as the system evolves. If advanced or AI-intensive behavior is introduced, the **default configuration must remain the lightweight decision model**. More complex behavior should only be available as an **explicit opt-in option**, clearly documented as having a measurable performance cost. Principles: - **Stability before intelligence** A stable system is always preferred over a smarter one. - **Performance is a shared resource** Any increase in bot cost affects all players and all bots. - **Simple logic scales better than smart logic** Predictable behavior under load is more valuable than perfect decisions. - **Complexity must justify itself** If a feature cannot clearly explain its cost, it should not exist. - **Defaults must be cheap** Expensive behavior must always be optional and clearly communicated. - **Bots should look reasonable, not perfect** The goal is believable behavior, not human simulation. Before submitting, confirm that this change aligns with those principles. --- ## Feature Evaluation Please answer the following: - Describe the **minimum logic** required to achieve the intended behavior? - Describe the **cheapest implementation** that produces an acceptable result? - Describe the **runtime cost** when this logic executes across many bots? --- ## How to Test the Changes - Step-by-step instructions to test the change - Any required setup (e.g. multiple players, bots, specific configuration) - Expected behavior and how to verify it ## Complexity & Impact Does this change add new decision branches? - - [ X] No - - [ ] Yes (**explain below**) Does this change increase per-bot or per-tick processing? - - [ X] No - - [ ] Yes (**describe and justify impact**) Could this logic scale poorly under load? - - [ X] No - - [ ] Yes (**explain why**) --- ## Defaults & Configuration Does this change modify default bot behavior? - - [ X] No - - [ ] Yes (**explain why**) If this introduces more advanced or AI-heavy logic: - - [ X] Lightweight mode remains the default - - [ ] More complex behavior is optional and thereby configurable --- ## AI Assistance Was AI assistance (e.g. ChatGPT or similar tools) used while working on this change? - - [ X] No - - [ ] Yes (**explain below**) If yes, please specify: - AI tool or model used (e.g. ChatGPT, GPT-4, Claude, etc.) - Purpose of usage (e.g. brainstorming, refactoring, documentation, code generation) - Which parts of the change were influenced or generated - Whether the result was manually reviewed and adapted AI assistance is allowed, but all submitted code must be fully understood, reviewed, and owned by the contributor. Any AI-influenced changes must be verified against existing CORE and PB logic. We expect contributors to be honest about what they do and do not understand. --- ## Final Checklist - - [ X] Stability is not compromised - - [ X] Performance impact is understood, tested, and acceptable - - [ X] Added logic complexity is justified and explained - - [ X] Documentation updated if needed --- ## Notes for Reviewers Please doublecheck if none of the timing-logic (migration from uint32 to microseconds) has been changed --------- Co-authored-by: Keleborn <22352763+Celandriel@users.noreply.github.com> Co-authored-by: bash <hermensb@gmail.com>
91 lines
2.5 KiB
C++
91 lines
2.5 KiB
C++
/*
|
|
* Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it
|
|
* and/or modify it under version 3 of the License, or (at your option), any later version.
|
|
*/
|
|
|
|
#ifndef _PLAYERBOT_STATSCOLLECTOR_H
|
|
#define _PLAYERBOT_STATSCOLLECTOR_H
|
|
|
|
#include "ItemTemplate.h"
|
|
#include "SpellInfo.h"
|
|
|
|
enum StatsType : uint8
|
|
{
|
|
// Basic stats
|
|
STATS_TYPE_AGILITY = 0,
|
|
STATS_TYPE_STRENGTH,
|
|
STATS_TYPE_INTELLECT,
|
|
STATS_TYPE_SPIRIT,
|
|
STATS_TYPE_STAMINA,
|
|
STATS_TYPE_HIT,
|
|
STATS_TYPE_CRIT,
|
|
STATS_TYPE_HASTE,
|
|
// Stats for tank
|
|
STATS_TYPE_ARMOR,
|
|
STATS_TYPE_DEFENSE,
|
|
STATS_TYPE_DODGE,
|
|
STATS_TYPE_PARRY,
|
|
STATS_TYPE_BLOCK_VALUE,
|
|
STATS_TYPE_BLOCK_RATING,
|
|
STATS_TYPE_RESILIENCE,
|
|
STATS_TYPE_HEALTH_REGENERATION,
|
|
// Stats for spell damage
|
|
STATS_TYPE_SPELL_POWER,
|
|
STATS_TYPE_SPELL_PENETRATION,
|
|
// Stats for heal
|
|
STATS_TYPE_HEAL_POWER,
|
|
STATS_TYPE_MANA_REGENERATION,
|
|
// Stats for physical damage and melee
|
|
STATS_TYPE_ATTACK_POWER,
|
|
STATS_TYPE_ARMOR_PENETRATION,
|
|
STATS_TYPE_EXPERTISE,
|
|
// Stats for weapon dps
|
|
STATS_TYPE_MELEE_DPS,
|
|
STATS_TYPE_RANGED_DPS,
|
|
// Bonus for unrecognized stats
|
|
STATS_TYPE_BONUS,
|
|
STATS_TYPE_MAX = 26
|
|
};
|
|
|
|
enum CollectorType : uint8
|
|
{
|
|
MELEE_DMG = 1,
|
|
MELEE_TANK = 2,
|
|
RANGED = 4,
|
|
SPELL_DMG = 8,
|
|
SPELL_HEAL = 16,
|
|
MELEE = MELEE_DMG | MELEE_TANK,
|
|
SPELL = SPELL_DMG | SPELL_HEAL
|
|
};
|
|
|
|
class StatsCollector
|
|
{
|
|
public:
|
|
StatsCollector(CollectorType type, int32 cls = -1);
|
|
StatsCollector(StatsCollector& stats) = default;
|
|
void Reset();
|
|
void CollectItemStats(ItemTemplate const* proto);
|
|
void CollectSpellStats(uint32 spellId, float multiplier = 1.0f, Milliseconds spellCooldown = -1ms);
|
|
void CollectEnchantStats(SpellItemEnchantmentEntry const* enchant, uint32 default_enchant_amount = 0);
|
|
bool CanBeTriggeredByType(SpellInfo const* spellInfo, uint32 procFlags, bool strict = true);
|
|
bool CheckSpellValidation(uint32 spellFamilyName, flag96 spelFalimyFlags, bool strict = true);
|
|
|
|
public:
|
|
float stats[STATS_TYPE_MAX];
|
|
|
|
private:
|
|
void CollectByItemStatType(uint32 itemStatType, int32 val);
|
|
bool SpecialSpellFilter(uint32 spellId);
|
|
bool SpecialEnchantFilter(uint32 enchantSpellId);
|
|
|
|
void HandleApplyAura(const SpellEffectInfo& effectInfo, float multiplier, bool canNextTrigger,
|
|
Milliseconds triggerCooldown);
|
|
float AverageValue(const SpellEffectInfo& effectInfo);
|
|
|
|
private:
|
|
CollectorType type_;
|
|
uint32 cls_;
|
|
};
|
|
|
|
#endif
|