mirror of
https://github.com/liyunfan1223/mod-playerbots.git
synced 2026-06-20 23:49:25 +02:00
d0ba99f381
Added a Windows CI fix to build with Ninja and avoid Windows
command-line length failures.
<!--
Thank you for contributing to mod-playerbots, please make sure that
you...
1. Submit your PR to the test-staging branch, not master.
2. Read the guidelines below before submitting.
3. Don't delete parts of this template.
DESIGN PHILOSOPHY: We prioritize STABILITY, PERFORMANCE, AND
PREDICTABILITY over behavioral realism.
Every action and decision executes PER BOT AND PER TRIGGER. Small
increases in logic complexity scale
poorly across thousands of bots and negatively affect all. We prioritize
a stable system over a smarter
one. Bots don't need to behave perfectly; believable behavior is the
goal, not human simulation.
Default behavior must be cheap in processing; expensive behavior must be
opt-in.
Before submitting, make sure your changes aligns with these principles.
-->
## Pull Request Description
This PR updates the Windows CI workflow to build AzerothCore +
mod-playerbots reliably with Ninja instead of the Visual Studio/MSBuild
generator.
The previous Windows build could fail during the final `worldserver`
build steps because MSBuild/RC generated command lines that exceeded
Windows command-line limits. Enabling long-path support was not enough,
because the failure was caused by tool command length rather than only
filesystem path length.
This workflow now:
- installs and uses Ninja as the CMake generator;
- creates an AzerothCore `conf/config.sh` for CI;
- forces the compiler to MSVC `cl`;
- enables CMake/Ninja response files to reduce command-line length;
- moves the source tree to a short path (`C:\ac`) before configuring and
building.
This keeps the Windows build on MSVC while avoiding the MSBuild/RC
command-line length issue.
**Pros:**
- Fixes Windows CI command-line length failures;
- avoids unreliable `rc.exe` / `MSB6003` errors from the MSBuild
generator;
- keeps the build on MSVC;
- makes the Windows CI build more predictable;
- does not affect runtime code or bot behavior.
**Cons:**
- Visual Studio project files (`.vcxproj`) are no longer generated in
CI;
- the workflow now copies the source tree to a short path before
building.
## Feature Evaluation
- Minimum logic: CI-only workflow changes to use Ninja, force MSVC,
enable response files, and build from a short path.
- Processing cost: None at runtime. This only affects GitHub Actions
build tooling.
## How to Test the Changes
- Run the Windows CI workflow on GitHub Actions.
- Confirm that CMake reports `-- Building for: Ninja`.
- Confirm that CMake detects MSVC as the C and C++ compiler.
- Confirm that the Windows build completes successfully.
- Confirm that no MSBuild `MSB6003`, `rc.exe`, or Ninja `CreateProcess`
command-line length errors occur.
## Impact Assessment
- Does this change increase per-bot/per-tick processing or risk scaling
poorly with thousands of bots?
- [x] No, not at all
- Does this change modify default bot behavior?
- [x] No
- Does this change add new decision branches or increase maintenance
complexity?
- [x] No
## AI Assistance
Was AI assistance used while working on this change?
- [x] No
Maybe if should so i'd made less commits...
## Final Checklist
- [x] Stability is not compromised.
- [x] Performance impact is understood, tested, and acceptable.
- [x] Added logic complexity is justified and explained.
- [x] Any new bot dialogue lines are translated.
- [x] Documentation updated if needed (Conf comments, WiKi commands).
## Notes for Reviewers
This change is CI-only and does not affect gameplay, bot logic, database
logic, or runtime performance.
The Windows workflow was failing because generated build commands became
too long for Windows process creation. Switching the CI build to Ninja,
forcing MSVC, enabling response files, and building from `C:\ac` fixes
the issue while keeping the compiler/toolchain consistent with the
Windows target.
---------
Co-authored-by: Keleborn <22352763+Celandriel@users.noreply.github.com>
Co-authored-by: bash <hermensb@gmail.com>
Co-authored-by: Revision <tkn963@gmail.com>
Co-authored-by: kadeshar <kadeshar@gmail.com>