mirror of
https://github.com/liyunfan1223/mod-playerbots.git
synced 2026-06-20 15:39:25 +02:00
439293e100
# Pull Request
Removed unused variables and fixed styling issues.
## How to Test the Changes
- Step-by-step instructions to test the change
- Any required setup (e.g. multiple players, bots, specific
configuration)
- Expected behavior and how to verify it
## Complexity & Impact
- Does this change add new decision branches?
- [x] No
- [] Yes (**explain below**)
- Does this change increase per-bot or per-tick processing?
- [x] No
- [ ] Yes (**describe and justify impact**)
- Could this logic scale poorly under load?
- [x] No
- [ ] Yes (**explain why**)
---
## Defaults & Configuration
- Does this change modify default bot behavior?
- [x] No
- [ ] Yes (**explain why**)
If this introduces more advanced or AI-heavy logic:
- [ ] Lightweight mode remains the default
- [ ] More complex behavior is optional and thereby configurable
---
## AI Assistance
- Was AI assistance (e.g. ChatGPT or similar tools) used while working
on this change?
- [x] No
- [ ] Yes (**explain below**)
---
## Final Checklist
- [x] Stability is not compromised
- [x] Performance impact is understood, tested, and acceptable
- [x] Added logic complexity is justified and explained
- [x] Documentation updated if needed
---
## Notes for Reviewers
This was filtered from the code provided by SmashingQuasar. Eliminated
variables were confirmed to be not used, but unclear at times if that is
due to mistakes in writing.
---------
Co-authored-by: bashermens <31279994+hermensbas@users.noreply.github.com>
69 lines
1.9 KiB
C++
69 lines
1.9 KiB
C++
#include "Playerbots.h"
|
|
#include "GundrakActions.h"
|
|
|
|
bool AvoidPoisonNovaAction::Execute(Event /*event*/)
|
|
{
|
|
Unit* boss = AI_VALUE2(Unit*, "find target", "slad'ran");
|
|
if (!boss) { return false; }
|
|
|
|
float distance = bot->GetExactDist2d(boss->GetPosition());
|
|
float radius = 15.0f;
|
|
float distanceExtra = 2.0f;
|
|
|
|
if (distance < radius + distanceExtra)
|
|
{
|
|
return MoveAway(boss, radius + distanceExtra - distance);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool AttackSnakeWrapAction::Execute(Event /*event*/)
|
|
{
|
|
Unit* boss = AI_VALUE2(Unit*, "find target", "slad'ran");
|
|
if (!boss) { return false; }
|
|
|
|
// Target is not findable from threat table using AI_VALUE2(),
|
|
// therefore need to search manually for the unit name
|
|
GuidVector targets = AI_VALUE(GuidVector, "possible targets no los");
|
|
|
|
for (auto& target : targets)
|
|
{
|
|
Unit* unit = botAI->GetUnit(target);
|
|
if (unit && unit->GetEntry() == NPC_SNAKE_WRAP)
|
|
{
|
|
Unit* currentTarget = AI_VALUE(Unit*, "current target");
|
|
if (!currentTarget || currentTarget->GetEntry() != NPC_SNAKE_WRAP)
|
|
{
|
|
return Attack(unit);
|
|
}
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool AvoidWhirlingSlashAction::Execute(Event /*event*/)
|
|
{
|
|
Unit* boss = AI_VALUE2(Unit*, "find target", "gal'darah");
|
|
if (!boss) { return false; }
|
|
|
|
float distance = bot->GetExactDist2d(boss->GetPosition());
|
|
float radius = 5.0f;
|
|
float distanceExtra = 2.0f;
|
|
|
|
if (distance < radius + distanceExtra)
|
|
{
|
|
if (botAI->IsTank(bot))
|
|
{
|
|
// The boss chases tank during this, leads to jittery stutter-stepping
|
|
// by the tank if we don't pre-move additional range. 2*radius seems ok
|
|
return MoveAway(boss, (2.0f * radius) + distanceExtra - distance);
|
|
}
|
|
// else
|
|
return MoveAway(boss, radius + distanceExtra - distance);
|
|
}
|
|
|
|
return false;
|
|
}
|