mirror of
https://github.com/liyunfan1223/mod-playerbots.git
synced 2026-06-20 15:39:25 +02:00
<!-- Thank you for contributing to mod-playerbots, please make sure that you... 1. Submit your PR to the test-staging branch, not master. 2. Read the guidelines below before submitting. 3. Don't delete parts of this template. DESIGN PHILOSOPHY: We prioritize STABILITY, PERFORMANCE, AND PREDICTABILITY over behavioral realism. Every action and decision executes PER BOT AND PER TRIGGER. Small increases in logic complexity scale poorly across thousands of bots and negatively affect all. We prioritize a stable system over a smarter one. Bots don't need to behave perfectly; believable behavior is the goal, not human simulation. Default behavior must be cheap in processing; expensive behavior must be opt-in. Before submitting, make sure your changes aligns with these principles. --> ## Pull Request Description <!-- Describe what this change does and why it is needed --> Replaced hardcoded bot text with translationable. Related with: #1295 ## How to Test the Changes <!-- - Step-by-step instructions to test the change. - Any required setup (e.g. multiple players, number of bots, specific configuration). - Expected behavior and how to verify it. --> 1. Invite bots 2. Check that text after "follow" and "stay" return texts "Following" and "Staying" ## Impact Assessment <!-- As a generic test, before and after measure of pmon (playerbot pmon tick) can help you here. --> - Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots? - - [x] No, not at all - - [ ] Minimal impact (**explain below**) - - [ ] Moderate impact (**explain below**) - Does this change modify default bot behavior? - - [x] No - - [ ] Yes (**explain why**) - Does this change add new decision branches or increase maintenance complexity? - - [x] No - - [ ] Yes (**explain below**) ## AI Assistance <!-- AI assistance is allowed, but all submitted code must be fully understood, reviewed, and owned by the contributor. We expect contributors to be honest about what they do and do not understand. --> Was AI assistance used while working on this change? - - [ ] No - - [x] Yes (**explain below**) <!-- If yes, please specify: - Purpose of usage (e.g. brainstorming, refactoring, documentation, code generation). - Which parts of the change were influenced or generated, and whether it was thoroughly reviewed. --> Summary hardcoded text and checking that they already exists to reuse. <!-- TRANSLATIONS: Anything new that the bots say in chat must be in a translatable format. This is done using GetBotTextOrDefault, which you can search for in the codebase to find examples. Your code needs to have English as the default fallback, while the full translations need to be in an SQL update file. The languages in the file are the nine language options supported by AzerothCore: English, Korean, French, German, Chinese, Taiwanese, Spanish, Spanish Mexico, and Russian. See data/sql/playerbots/updates/2025_12_27_ai_playerbot_fishing_text.sql as an example of a translation SQL update, whose content are called within the codebase at src/strategy/actions/FishingAction.cpp --> ## Final Checklist - - [x] Stability is not compromised. - - [x] Performance impact is understood, tested, and acceptable. - - [x] Added logic complexity is justified and explained. - - [x] Any new bot dialogue lines are translated. - - [x] Documentation updated if needed (Conf comments, WiKi commands). ## Notes for Reviewers <!-- Anything else that's helpful to review or test your pull request. -->
207 lines
5.8 KiB
C++
207 lines
5.8 KiB
C++
/*
|
|
* Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it
|
|
* and/or modify it under version 3 of the License, or (at your option), any later version.
|
|
*/
|
|
|
|
#include "AcceptQuestAction.h"
|
|
|
|
#include "Event.h"
|
|
#include "PlayerbotTextMgr.h"
|
|
#include "Playerbots.h"
|
|
|
|
bool AcceptAllQuestsAction::ProcessQuest(Quest const* quest, Object* questGiver)
|
|
{
|
|
if (!AcceptQuest(quest, questGiver->GetGUID())) return false;
|
|
|
|
auto text_quest = ChatHelper::FormatQuest(quest);
|
|
bot->PlayDistanceSound(620);
|
|
|
|
if (botAI->HasStrategy("debug quest", BotState::BOT_STATE_NON_COMBAT) || botAI->HasStrategy("debug rpg", BotState::BOT_STATE_COMBAT))
|
|
{
|
|
LOG_INFO("playerbots", "{} => Quest [{}] accepted", bot->GetName(), quest->GetTitle());
|
|
std::string text = PlayerbotTextMgr::instance().GetBotTextOrDefault(
|
|
"quest_accept_debug",
|
|
"Quest [%quest] accepted",
|
|
{{"%quest", text_quest}});
|
|
bot->Say(text, LANG_UNIVERSAL);
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
bool AcceptQuestAction::Execute(Event event)
|
|
{
|
|
Player* requester = event.getOwner() ? event.getOwner() : GetMaster();
|
|
if (!requester)
|
|
return false;
|
|
|
|
Player* bot = botAI->GetBot();
|
|
uint64_t guid;
|
|
uint32 quest = 0;
|
|
|
|
std::string const text = event.getParam();
|
|
PlayerbotChatHandler ch(requester);
|
|
quest = ch.extractQuestId(text);
|
|
|
|
bool hasAccept = false;
|
|
|
|
if (event.getPacket().empty())
|
|
{
|
|
GuidVector npcs = AI_VALUE(GuidVector, "nearest npcs");
|
|
for (auto i = npcs.begin(); i != npcs.end(); i++)
|
|
{
|
|
Unit* unit = botAI->GetUnit(*i);
|
|
if (unit && quest && unit->hasQuest(quest))
|
|
{
|
|
guid = unit->GetGUID().GetRawValue();
|
|
break;
|
|
}
|
|
if (unit && text == "*" && bot->GetDistance(unit) <= INTERACTION_DISTANCE)
|
|
hasAccept |= QuestAction::ProcessQuests(unit);
|
|
}
|
|
GuidVector gos = AI_VALUE(GuidVector, "nearest game objects no los");
|
|
for (auto i = gos.begin(); i != gos.end(); i++)
|
|
{
|
|
GameObject* go = botAI->GetGameObject(*i);
|
|
if (go && quest && go->hasQuest(quest))
|
|
{
|
|
guid = go->GetGUID().GetRawValue();
|
|
break;
|
|
}
|
|
if (go && text == "*" && bot->GetDistance(go) <= INTERACTION_DISTANCE)
|
|
hasAccept |= QuestAction::ProcessQuests(go);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
WorldPacket& p = event.getPacket();
|
|
p.rpos(0);
|
|
p >> guid >> quest;
|
|
}
|
|
|
|
if (!quest || !guid)
|
|
return false;
|
|
|
|
Quest const* qInfo = sObjectMgr->GetQuestTemplate(quest);
|
|
if (!qInfo)
|
|
return false;
|
|
|
|
hasAccept |= AcceptQuest(qInfo, ObjectGuid(guid));
|
|
|
|
if (hasAccept)
|
|
{
|
|
std::stringstream ss;
|
|
ss << "AcceptQuestAction [" << qInfo->GetTitle() << "] - [" << std::to_string(qInfo->GetQuestId()) << "]";
|
|
LOG_DEBUG("playerbots", "{}", ss.str().c_str());
|
|
// botAI->TellMaster(ss.str());
|
|
}
|
|
|
|
return hasAccept;
|
|
}
|
|
|
|
bool AcceptQuestShareAction::Execute(Event event)
|
|
{
|
|
Player* master = GetMaster();
|
|
Player* bot = botAI->GetBot();
|
|
|
|
WorldPacket& p = event.getPacket();
|
|
p.rpos(0);
|
|
uint32 quest;
|
|
p >> quest;
|
|
|
|
Quest const* qInfo = sObjectMgr->GetQuestTemplate(quest);
|
|
if (!qInfo || !bot->GetDivider())
|
|
return false;
|
|
|
|
quest = qInfo->GetQuestId();
|
|
|
|
if (bot->HasQuest(quest))
|
|
{
|
|
bot->SetDivider(ObjectGuid::Empty);
|
|
botAI->TellError(PlayerbotTextMgr::instance().GetBotTextOrDefault(
|
|
"quest_already_have_error", "I have this quest", {}));
|
|
return false;
|
|
}
|
|
|
|
if (!bot->CanTakeQuest(qInfo, false))
|
|
{
|
|
// can't take quest
|
|
bot->SetDivider(ObjectGuid::Empty);
|
|
botAI->TellError(PlayerbotTextMgr::instance().GetBotTextOrDefault(
|
|
"quest_cant_take_error", "I can't take this quest", {}));
|
|
|
|
return false;
|
|
}
|
|
|
|
if (!bot->GetDivider().IsEmpty())
|
|
{
|
|
// send msg to quest giving player
|
|
master->SendPushToPartyResponse(bot, QUEST_PARTY_MSG_ACCEPT_QUEST);
|
|
bot->SetDivider(ObjectGuid::Empty);
|
|
}
|
|
|
|
if (bot->CanAddQuest(qInfo, false))
|
|
{
|
|
bot->AddQuest(qInfo, master);
|
|
|
|
if (bot->CanCompleteQuest(quest))
|
|
bot->CompleteQuest(quest);
|
|
|
|
// Runsttren: did not add typeid switch from WorldSession::HandleQuestgiverAcceptQuestOpcode!
|
|
// I think it's not needed, cause typeid should be TYPEID_PLAYER - and this one is not handled
|
|
// there and there is no default case also.
|
|
|
|
if (qInfo->GetSrcSpell() > 0)
|
|
{
|
|
bot->CastSpell(bot, qInfo->GetSrcSpell(), true);
|
|
}
|
|
|
|
botAI->TellMaster(PlayerbotTextMgr::instance().GetBotTextOrDefault(
|
|
"quest_accept", "Quest accepted", {}));
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool ConfirmQuestAction::Execute(Event event)
|
|
{
|
|
Player* bot = botAI->GetBot();
|
|
Player* requester = event.getOwner() ? event.getOwner() : GetMaster();
|
|
|
|
WorldPacket& p = event.getPacket();
|
|
p.rpos(0);
|
|
uint32 quest;
|
|
p >> quest;
|
|
Quest const* qInfo = sObjectMgr->GetQuestTemplate(quest);
|
|
|
|
if (!qInfo)
|
|
return false;
|
|
|
|
quest = qInfo->GetQuestId();
|
|
if (!bot->CanTakeQuest(qInfo, false))
|
|
{
|
|
// can't take quest
|
|
// botAI->TellError("quest_cant_take");
|
|
return false;
|
|
}
|
|
|
|
if (bot->CanAddQuest(qInfo, false))
|
|
{
|
|
bot->AddQuest(qInfo, requester);
|
|
|
|
if (bot->CanCompleteQuest(quest))
|
|
bot->CompleteQuest(quest);
|
|
|
|
if (qInfo->GetSrcSpell() > 0)
|
|
{
|
|
bot->CastSpell(bot, qInfo->GetSrcSpell(), true);
|
|
}
|
|
|
|
// botAI->TellMaster("quest_accept");
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|