138 Commits

Author SHA1 Message Date
bash
8d51092d42
As requested revert for threadfixes last few days (#1552)
* Revert "[Large server fix] #1537 Serialize playerBots/botLoading with a mutex and use snapshot-based loops to fix concurrency crashes (#1540)"

This reverts commit 3fff58df1a2058894e9b758be07869aec87c2c70.

* Revert "[Fix] teleport to invalid map or invalid coordinates (x , y , z  200000, o ) given when teleporting player (g UI d full type player low , name , map , x , y , z , o )  (#1538)"

This reverts commit ca2e2ef0dbd8dcfb16123db65ae638424550e50c.

* Revert "Fix: prevent MoveSplineInitArgs::Validate velocity asserts (velocity > 0.01f) for bots, pets, and charmed units (#1534)"

This reverts commit 4e3ac609bd23d991150d956d4e69ee6de2fcf2bf.

* Revert "[Fix issue #1527] : startup crash in tank target selection — add TOCTOU & null-safety guards (#1532)"

This reverts commit c6b0424c29b6a1bf5b3574135128d30d19838411.

* Revert "[Fix issue #1528] Close small window where the “in a BG/arena” state can change between the check (InBattleground() / InArena()) and grabbing the pointer (GetBattleground()), which leads to a null dereference. (#1530)"

This reverts commit 2e0a161623eaa97b7d9ceea076779ae0cabeb877.

* Revert "Harden playerbot logout & packet dispatch; add null-safety in chat hooks and RPG checks (#1529)"

This reverts commit e4ea8e2694b0f6d098a945c6f863526cd14f9b3f.

* Revert "Dont wait to travel when in combat. (#1524)"

This reverts commit ddfa919154529fee59e7ba30d2ebe29c0ae4abdf.

* Revert "nullptr fix (#1523)"

This reverts commit 380312ffd231fd5e663a8a17daa80dd39906e3f0.

* Revert "Playerbots/LFG: fix false not eligible & dungeon 0/type 0, add clear diagnostics (#1521)"

This reverts commit 872e4176137b66c83ebcb03932fa8ff1e39fd791.

* Revert "nullptr exception (#1520)"

This reverts commit 3d28a815089fd0a878a6a1d469db657c6030d4b2.

* Revert "Removed bot freezing at startup and system message, not relevant anymore (#1519)"

This reverts commit bcd6f5bc066d5e8a54f2d37b7dfc54e5db0dd2d1.
2025-08-12 22:10:47 +02:00
Alex Dcnh
4e3ac609bd
Fix: prevent MoveSplineInitArgs::Validate velocity asserts (velocity > 0.01f) for bots, pets, and charmed units (#1534)
* MoveSplineInitArgs::Validate: expression 'velocity > 0.01f' failed for GUID Full

* Update BotMovementUtils.h
2025-08-12 01:53:48 +02:00
Yunfan Li
f0c6aaff0b Random bots gear related enhancements 2025-07-05 20:29:34 +08:00
Type1Error
f55e95da9d
fix(#1250): Fix movement animation desync after CC effects This fixes a bug where playerbots fail to display proper movement animations after crowd control effects wear off. When affected by movement-restricting abilities (e.g., Net-o-Matic Projector), bots would abruptly snap between positions instead of transitioning smoothly with walking or running animations. (#1264)
Fix: Better handling of CC state transitions in bot movement:
    - Added wasMovementRestricted to track CC status
    - Enhanced UpdateMovementState() to detect and react to CC ending
    - Triggered movement flag update to fix animation desync

This ensures proper client-server movement synchronization and resolves the visual bug where bots appeared to jump or skip positions. The fix restores the correct movement animation state, replicating the effect previously achieved with the reset or summon commands.
2025-05-05 15:07:16 +02:00
Yunfan Li
19447c3914
Enable new rpg strategy by default (#1192)
* Add RandomBotMinLevelChance

* Save mana only for healer

* Disable addclass dk for low level player

* Target selection and debuff cast with less players in group

* Change default rpg strategy and bots count in config

* Logs clean up

* Improve init=auto

* Remove login logs after initialization

* Rndbots stats for quest

* Prediction chase in reach combat

* Poor & Normal items ensurence for init=auto
2025-04-11 20:31:38 +08:00
kadeshar
fe519854a4
- Added skipping disperse tactic while bot is in stay stance (#1180) 2025-04-08 20:55:07 +08:00
Yunfan Li
24efa7efa2
General improvement on init and strats (#1064)
* Potions strats and potions init

* Druid and shaman spell in low level

* Ammo init improvement

* Rogue low level

* Fix melee attack action (for caster with no mana)

* Disable pet spells that reduce dps

* Talents improvement

* Remove CanFreeMove check

* Reduce penalty for non-dagger weapon for rogue
2025-03-08 12:36:06 +01:00
Yunfan Li
95c2ba9105
Permission check and readability improvements (#997)
* AiFactory check by spell instead of level

* Ignore group security for guild invitation
2025-02-23 20:09:59 +01:00
Yunfan Li
4b1febc62a
Minor improvments on logs, stats weights and aoe distance calculation (#995)
* StatsCollector for paladin spell

* Remove error log on MoveFromGroup

* Log and timer for CreateRandomBots

* Improve aoe trigger distance calculation

* Reduce spirit weights for heal priest and paladin
2025-02-22 10:57:33 +08:00
SaW
2ebeb244ec
Fix bot swimming behavior at the surface and in shallow waters (#908)
- Fix for Bots don't swim properly near the surface #903
- Prevents bots teleporting/warping to the surface when in (shallow) waters.
2025-01-25 16:30:47 +01:00
Yunfan Li
f6cc3f6e40
Improve ICC spread and fix Valithria trigger (#884)
* Temp fix valithria find target

* Improve spread with FleePosition

* Fix Valithria trigger
2025-01-21 20:24:06 +01:00
Yunfan Li
da1c3effb7 Fix movement after spell cast 2025-01-01 20:41:08 +08:00
Yunfan Li
1b5c6ba06a Fix FleeAction 2024-12-31 21:53:31 +08:00
Yunfan Li
cc5a3e4c76 Add backwards paramater on MoveAway (apply only on FleeAction) 2024-12-31 20:56:25 +08:00
Yunfan Li
79a5fdd7c1 Make backwards movement for flee 2024-12-29 23:21:03 +08:00
Yunfan Li
6d82b134d1 Merge branch 'master' into new_rpg_strats 2024-12-06 20:39:51 +08:00
Revision
f0ccb0a371 Fix compiler errors and switch to using available helpers 2024-12-02 00:16:06 +01:00
Yunfan Li
0fd894176b [New Rpg] New rpg start up (add GO_GRIND and NEAR_RANDOM status) 2024-11-30 23:48:29 +08:00
Yunfan Li
2cedf3f05b [Sync] Core sync 20241030 2024-10-30 21:10:43 +08:00
Bobblybook
b526a07303 Generalise dragon flanking action 2024-10-12 23:51:00 +11:00
Yunfan Li
ff68a92fe9 [Movement] Modify combat reach calculation 2024-10-04 14:14:16 +08:00
Yunfan Li
773bb7c43d [Combat formation] Fix leftover code 2024-09-27 00:22:27 +08:00
Yunfan Li
5b8d8fbf6e [Tank target] Improve position 2024-09-26 20:02:37 +08:00
Yunfan Li
8d524cdaf0 [Combat formation] Compatible with naxx and avoid aoe 2024-09-26 20:01:10 +08:00
Yunfan Li
2756664b77 [Tank face] Improve angle calculation 2024-09-24 20:34:18 +08:00
Yunfan Li
eea652f5d5 Tank face and dps behind 2024-09-24 11:46:39 +08:00
Yunfan Li
b87ca9da4c Icecrown gunship strategy 2024-09-23 14:00:24 +08:00
Yunfan Li
68bf09c425 Disable test items 2024-09-18 22:16:18 +08:00
Yunfan Li
4de02481be Avoid aoe max radius and whitelist 2024-09-08 12:53:08 +08:00
Yunfan Li
927d893945 Improve combat reach and dps target, allowing spell interruption 2024-09-06 12:33:54 +08:00
Fuzz
87745590da aq20 ossirian strat 2024-09-01 20:09:35 +10:00
Fuzz
d29569e9ea added 'move from group' action/strat/shortcut-action 2024-08-26 22:30:36 +10:00
Yunfan Li
5a576cd9a5 Config option ApplyInstanceStrategies 2024-08-19 23:55:37 +08:00
Yunfan Li
47f8eb3e4a Ulduar flame leviathan (normal mode) 2024-08-19 19:30:04 +08:00
Yunfan Li
7b0bb20078 Movement priority 2024-08-14 18:37:21 +08:00
Yunfan Li
2b35aeb049 Collision check in movement 2024-08-12 11:52:33 +08:00
Yunfan Li
65579abb47 Fix transport movement 2024-08-12 02:27:36 +08:00
Fuzz
f1bfed190c [Battlegrounds] fixed bug I introduced in PR#422 where bots alternate mount/unmount near flag indefinately, also fixed other erroneous uses of sqrt on distances 2024-08-08 21:18:52 +10:00
Fuzz
5ce49299c4 cleaned up movement code (and left comment for liyunfan) 2024-08-06 19:56:20 +10:00
Fuzz
af674e9361 [Battlegrounds] many IOC fixes: fixed bots not being able to revive in their own base GY, fixed bots not able to use flags in IOC at all (couldnt cap anything), added path so bots could reach boss and several other paths too, fixed horde bots not being able to tell that alliance gate is down (stayed outside forever), fixed bots not able to get in vehicles, fixed bots not able to drive vehicles, fixed bots in vehicles becoming unresponsive after a fight (in-combat status seems to never clear in vehicle which may be AC bug), reduced bot 'agro distance' when in vehicle so they can get to their objective, redid selectObject strat completely, prevented bots using cannons (bots are useless in them) and catapults (they dont know how to use them), prevented bots using Glaive Thrower's Blade Salvo as it's bugged (and stops them using any attacks after they use it), many other fixes 2024-08-06 19:26:54 +10:00
Yunfan Li
264c533d1f Fix move delay and reach combat 2024-08-06 00:44:50 +08:00
Yunfan Li
4754252eeb Waypoint for move random 2024-08-05 14:14:43 +08:00
Yunfan Li
bb67c45e64 Code style 2024-08-05 12:12:00 +08:00
Yunfan Li
f706fa2ba6 Better waypoints for combat reach 2024-08-05 12:08:14 +08:00
Yunfan Li
1a92743dfd Allow spell casting during movement 2024-08-05 10:37:33 +08:00
Yunfan Li
53611c9040 Run clang-format 2024-08-04 10:23:36 +08:00
Yunfan Li
8df01e8fed Enable flight mount for bots 2024-08-03 00:01:40 +08:00
Fuzz
1855f0beae Merge branch 'master' into eots-fixes 2024-07-29 22:33:33 +10:00
Atidote
b8cea4a3a9
Merge branch 'liyunfan1223:master' into locale_fix 2024-07-28 10:52:13 +02:00
Revision
75475e3986 Fix debug message 2024-07-28 02:57:46 +02:00