From b187031ed26667ee9aa9beffa3ebeade3768efdd Mon Sep 17 00:00:00 2001 From: bash Date: Sat, 30 May 2026 23:55:23 +0200 Subject: [PATCH] fix(Core/Movement): ResolveMovePath takes WorldPosition by value (distance() not const-safe) --- src/Ai/Base/Actions/MovementActions.cpp | 7 +++---- src/Ai/Base/Actions/MovementActions.h | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/Ai/Base/Actions/MovementActions.cpp b/src/Ai/Base/Actions/MovementActions.cpp index c9396cab4..6154b0e77 100644 --- a/src/Ai/Base/Actions/MovementActions.cpp +++ b/src/Ai/Base/Actions/MovementActions.cpp @@ -3067,8 +3067,8 @@ bool MoveAwayFromPlayerWithDebuffAction::isPossible() } -TravelPath MovementAction::ResolveMovePath(WorldPosition const& startPos, - WorldPosition const& endPos, +TravelPath MovementAction::ResolveMovePath(WorldPosition startPos, + WorldPosition endPos, LastMovement& lastMove) { float const totalDistance = startPos.distance(endPos); @@ -3098,8 +3098,7 @@ TravelPath MovementAction::ResolveMovePath(WorldPosition const& startPos, } else { - WorldPosition mutableStart = startPos; - std::vector probe = mutableStart.getPathTo(endPos, bot); + std::vector probe = startPos.getPathTo(endPos, bot); out.addPath(probe); } diff --git a/src/Ai/Base/Actions/MovementActions.h b/src/Ai/Base/Actions/MovementActions.h index a83c06fc3..3ee063b5b 100644 --- a/src/Ai/Base/Actions/MovementActions.h +++ b/src/Ai/Base/Actions/MovementActions.h @@ -94,8 +94,8 @@ protected: // graph (cross-map / >sightDistance) or live mmap probe, regression // guard preferring cached path when no better, fall back to a // single-point path on dest. Stateless — does not dispatch. - TravelPath ResolveMovePath(WorldPosition const& startPos, - WorldPosition const& endPos, + TravelPath ResolveMovePath(WorldPosition startPos, + WorldPosition endPos, LastMovement& lastMove); // Dispatches the head-of-path special segment (portal interact /