Will of the forsaken (#2231)

<!--
Thank you for contributing to mod-playerbots, please make sure that
you...
1. Submit your PR to the test-staging branch, not master.
2. Read the guidelines below before submitting.
3. Don't delete parts of this template.

DESIGN PHILOSOPHY: We prioritize STABILITY, PERFORMANCE, AND
PREDICTABILITY over behavioral realism.

Every action and decision executes PER BOT AND PER TRIGGER. Small
increases in logic complexity scale
poorly across thousands of bots and negatively affect all. We prioritize
a stable system over a smarter
one. Bots don't need to behave perfectly; believable behavior is the
goal, not human simulation.
Default behavior must be cheap in processing; expensive behavior must be
opt-in.

Before submitting, make sure your changes aligns with these principles.
-->

## Pull Request Description
<!-- Describe what this change does and why it is needed -->
Added Will of the Forsaken support. 
Made structure fix for affected files.

Partially resolves: #2002 

## How to Test the Changes
<!--
- Step-by-step instructions to test the change.
- Any required setup (e.g. multiple players, number of bots, specific
configuration).
- Expected behavior and how to verify it.
-->
- create/invite undead bot
- start fight (you can use dummy target)
- use `.aura 6215` to fear bot
- bot should use "Will of the Forsaken" to remove debuff


## Impact Assessment
<!-- As a generic test, before and after measure of pmon (playerbot pmon
tick) can help you here. -->
- Does this change increase per-bot/per-tick processing or risk scaling
poorly with thousands of bots?
    - - [x] No, not at all
    - - [ ] Minimal impact (**explain below**)
    - - [ ] Moderate impact (**explain below**)



- Does this change modify default bot behavior?
    - - [ ] No
    - - [x] Yes (**explain why**)

Undead bot use now "Will of the Forsaken" to remove charm, fear or
sleep.

- Does this change add new decision branches or increase maintenance
complexity?
    - - [x] No
    - - [ ] Yes (**explain below**)



## Messages to Translate
<!--
Bot messages have to be translatable, but you don't need to do the
translations here. You only need to make sure
the message is in a translatable format, and list in the table the
message_key and the default English message.
Search for GetBotTextOrDefault in the codebase for examples.
-->
- Does this change add bot messages to translate?
    - - [x] No
    - - [ ] Yes (**list messages in the table**)

| Message key  | Default message |
| --------------- | ------------------ |
|			 |			      |
|			 |			      |

## AI Assistance
<!--
AI assistance is allowed, but all submitted code must be fully
understood, reviewed, and owned by the contributor.
We expect contributors to be honest about what they do and do not
understand.
-->
- Was AI assistance used while working on this change?
    - - [ ] No
    - - [x] Yes (**explain below**)
<!--
If yes, please specify:
- Purpose of usage (e.g. brainstorming, refactoring, documentation, code
generation).
- Which parts of the change were influenced or generated, and whether it
was thoroughly reviewed.
-->

OpenCode to review changes


## Final Checklist

- - [x] Stability is not compromised.
- - [x] Performance impact is understood, tested, and acceptable.
- - [x] Added logic complexity is justified and explained.
- - [x] Documentation updated if needed (Conf comments, WiKi commands).

## Notes for Reviewers
<!-- Anything else that's helpful to review or test your pull request.
-->

<img width="325" height="77" alt="obraz"
src="https://github.com/user-attachments/assets/729cfdf8-3742-457c-9278-7fcce824e6d0"
/>

---------

Co-authored-by: Keleborn <22352763+Celandriel@users.noreply.github.com>

src/Ai/Base/ActionContext.h

@@ -165,6 +165,7 @@ public:
         creators["blood fury"] = &ActionContext::blood_fury;
         creators["berserking"] = &ActionContext::berserking;
         creators["every man for himself"] = &ActionContext::every_man_for_himself;
+        creators["will of the forsaken"] = &ActionContext::will_of_the_forsaken;
         creators["use trinket"] = &ActionContext::use_trinket;
         creators["auto talents"] = &ActionContext::auto_talents;
         creators["auto share quest"] = &ActionContext::auto_share_quest;
@@ -361,6 +362,7 @@ private:
     static Action* blood_fury(PlayerbotAI* botAI) { return new CastBloodFuryAction(botAI); }
     static Action* berserking(PlayerbotAI* botAI) { return new CastBerserkingAction(botAI); }
     static Action* every_man_for_himself(PlayerbotAI* botAI) { return new CastEveryManForHimselfAction(botAI); }
+    static Action* will_of_the_forsaken(PlayerbotAI* botAI) { return new CastWillOfTheForsakenAction(botAI); }
     static Action* use_trinket(PlayerbotAI* botAI) { return new UseTrinketAction(botAI); }
     static Action* auto_talents(PlayerbotAI* botAI) { return new AutoSetTalentsAction(botAI); }
     static Action* auto_share_quest(PlayerbotAI* ai) { return new AutoShareQuestAction(ai); }

src/Ai/Base/Actions/GenericBuffUtils.h

@@ -1,63 +0,0 @@
-/*
- * Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it
- * and/or modify it under version 3 of the License, or (at your option), any later version.
- */
-
-#pragma once
-
-#include <string>
-#include <functional>
-#include "Common.h"
-#include "Group.h"
-#include "Chat.h"
-#include "Language.h"
-
-class Player;
-class PlayerbotAI;
-
-namespace ai::buff
-{
-
-    // Build an aura qualifier "single + greater" to avoid double-buffing
-    std::string MakeAuraQualifierForBuff(std::string const& name);
-
-    // Returns the group spell name for a given single-target buff.
-    // If no group equivalent exists, returns "".
-    std::string GroupVariantFor(std::string const& name);
-
-    // Checks if the bot has the required reagents to cast a spell (by its spellId).
-    // Returns false if the spellId is invalid.
-    bool HasRequiredReagents(Player* bot, uint32 spellId);
-
-    // Applies the "switch to group buff" policy if: the bot is in a group of size x+,
-    // the group variant is known/useful, and reagents are available. Otherwise, returns baseName.
-    // If announceOnMissing == true and reagents are missing, calls the 'announce' callback
-    // (if provided) to notify the party/raid.
-    std::string UpgradeToGroupIfAppropriate(
-        Player* bot,
-        PlayerbotAI* botAI,
-        std::string const& baseName,
-        bool announceOnMissing = false,
-        std::function<void(std::string const&)> announce = {}
-    );
-}
-
-namespace ai::chat {
-    inline std::function<void(std::string const&)> MakeGroupAnnouncer(Player* me)
-    {
-        return [me](std::string const& msg)
-        {
-            if (Group* g = me->GetGroup())
-            {
-                WorldPacket data;
-                ChatMsg type = g->isRaidGroup() ? CHAT_MSG_RAID : CHAT_MSG_PARTY;
-                ChatHandler::BuildChatPacket(data, type, LANG_UNIVERSAL, me, /*receiver=*/nullptr, msg.c_str());
-                g->BroadcastPacket(&data, true, -1, me->GetGUID());
-            }
-            else
-            {
-                me->Say(msg, LANG_UNIVERSAL);
-            }
-        };
-    }
-}

src/Ai/Base/Actions/GenericSpellActions.cpp

@@ -17,10 +17,11 @@
 #include "WorldPacket.h"
 #include "Group.h"
 #include "Chat.h"
-#include "GenericBuffUtils.h"
+#include "Ai/Base/Util/GenericBuffUtils.h"
 #include "PlayerbotAI.h"
 
 using ai::buff::MakeAuraQualifierForBuff;
+using ai::spell::HasSpellOrCategoryCooldown;
 
 CastSpellAction::CastSpellAction(PlayerbotAI* botAI, std::string const spell)
     : Action(botAI, spell), range(botAI->GetRange("spell")), spell(spell)
@@ -320,7 +321,7 @@ bool CastEveryManForHimselfAction::isPossible()
     if (!bot->HasSpell(spellId))
         return false;
 
-    if (bot->HasSpellCooldown(spellId))
+    if (HasSpellOrCategoryCooldown(bot, spellId))
         return false;
 
     return true;
@@ -328,11 +329,36 @@ bool CastEveryManForHimselfAction::isPossible()
 
 bool CastEveryManForHimselfAction::isUseful()
 {
-    return bot->HasAuraType(SPELL_AURA_MOD_STUN) ||
+    return (bot->HasAuraType(SPELL_AURA_MOD_STUN) ||
            bot->HasAuraType(SPELL_AURA_MOD_FEAR) ||
            bot->HasAuraType(SPELL_AURA_MOD_ROOT) ||
            bot->HasAuraType(SPELL_AURA_MOD_CONFUSE) ||
-           bot->HasAuraType(SPELL_AURA_MOD_CHARM);
+           bot->HasAuraType(SPELL_AURA_MOD_CHARM))
+        && CastSpellAction::isUseful();
+}
+
+bool CastWillOfTheForsakenAction::isPossible()
+{
+    uint32 spellId = AI_VALUE2(uint32, "spell id", spell);
+    if (!spellId)
+        return false;
+
+    if (!bot->HasSpell(spellId))
+        return false;
+
+    if (HasSpellOrCategoryCooldown(bot, spellId))
+        return false;
+
+    return true;
+}
+
+bool CastWillOfTheForsakenAction::isUseful()
+{
+    return (bot->HasAuraType(SPELL_AURA_MOD_FEAR) ||
+           bot->HasAuraType(SPELL_AURA_MOD_CHARM) ||
+           bot->HasAuraType(SPELL_AURA_AOE_CHARM) ||
+           bot->HasAuraWithMechanic(1 << MECHANIC_SLEEP))
+        && CastSpellAction::isUseful();
 }
 
 bool UseTrinketAction::Execute(Event /*event*/)

src/Ai/Base/Actions/GenericSpellActions.h

@@ -294,6 +294,16 @@ public:
     bool isUseful() override;
 };
 
+class CastWillOfTheForsakenAction : public CastSpellAction
+{
+public:
+    CastWillOfTheForsakenAction(PlayerbotAI* botAI) : CastSpellAction(botAI, "will of the forsaken") {}
+
+    std::string const GetTargetName() override { return "self target"; }
+    bool isPossible() override;
+    bool isUseful() override;
+};
+
 class UseTrinketAction : public Action
 {
 public:

src/Ai/Base/Strategy/RacialsStrategy.cpp

@@ -37,6 +37,9 @@ void RacialsStrategy::InitTriggers(std::vector<TriggerNode*>& triggers)
     triggers.push_back(new TriggerNode(
         "loss of control", { NextAction("every man for himself", ACTION_EMERGENCY + 1) }));
 
+    triggers.push_back(new TriggerNode(
+        "fear charm sleep", { NextAction("will of the forsaken", ACTION_EMERGENCY + 1) }));
+
 }
 
 RacialsStrategy::RacialsStrategy(PlayerbotAI* botAI) : Strategy(botAI)

src/Ai/Base/Trigger/GenericTriggers.cpp

@@ -473,6 +473,14 @@ bool LossOfControlTrigger::IsActive()
            bot->HasAuraType(SPELL_AURA_MOD_CHARM);
 }
 
+bool FearCharmSleepTrigger::IsActive()
+{
+    return bot->HasAuraType(SPELL_AURA_MOD_FEAR) ||
+           bot->HasAuraType(SPELL_AURA_MOD_CHARM) ||
+           bot->HasAuraType(SPELL_AURA_AOE_CHARM) ||
+           bot->HasAuraWithMechanic(1 << MECHANIC_SLEEP);
+}
+
 bool HasAuraStackTrigger::IsActive()
 {
     Aura* aura = botAI->GetAura(getName(), GetTarget(), false, true, stack);

src/Ai/Base/Trigger/GenericTriggers.h

@@ -754,6 +754,14 @@ public:
     bool IsActive() override;
 };
 
+class FearCharmSleepTrigger : public Trigger
+{
+public:
+    FearCharmSleepTrigger(PlayerbotAI* botAI) : Trigger(botAI, "fear charm sleep", 1) {}
+
+    bool IsActive() override;
+};
+
 class IsSwimmingTrigger : public Trigger
 {
 public:

src/Ai/Base/TriggerContext.h

@@ -61,6 +61,7 @@ public:
 
         creators["generic boost"] = &TriggerContext::generic_boost;
         creators["loss of control"] = &TriggerContext::loss_of_control;
+        creators["fear charm sleep"] = &TriggerContext::fear_charm_sleep;
 
         creators["protect party member"] = &TriggerContext::protect_party_member;
 
@@ -367,6 +368,7 @@ private:
     }
     static Trigger* generic_boost(PlayerbotAI* botAI) { return new GenericBoostTrigger(botAI); }
     static Trigger* loss_of_control(PlayerbotAI* botAI) { return new LossOfControlTrigger(botAI); }
+    static Trigger* fear_charm_sleep(PlayerbotAI* botAI) { return new FearCharmSleepTrigger(botAI); }
     static Trigger* PartyMemberCriticalHealth(PlayerbotAI* botAI)
     {
         return new PartyMemberCriticalHealthTrigger(botAI);

src/Ai/Base/Util/GenericBuffUtils.cpp

@@ -67,7 +67,7 @@ namespace ai::buff
                 if (info->Reagent[i] > 0)
                 {
                     uint32 const itemId = info->Reagent[i];
-                    int32  const need   = info->ReagentCount[i];
+                    int32 const need = info->ReagentCount[i];
                     if ((int32)bot->GetItemCount(itemId, false) < need)
                         return false;
                 }
@@ -143,3 +143,28 @@ namespace ai::buff
         return castName;
     }
 }
+
+namespace ai::spell
+{
+    bool HasSpellOrCategoryCooldown(Player* bot, uint32 spellId)
+    {
+        if (bot->HasSpellCooldown(spellId))
+            return true;
+
+        SpellInfo const* spellInfo = sSpellMgr->GetSpellInfo(spellId);
+        if (!spellInfo)
+            return false;
+
+        uint32 category = spellInfo->GetCategory();
+        if (!category)
+            return false;
+
+        for (auto const& [cooldownSpellId, cooldown] : bot->GetSpellCooldownMap())
+        {
+            if (cooldown.category == category && bot->GetSpellCooldownDelay(cooldownSpellId) > 0)
+                return true;
+        }
+
+        return false;
+    }
+}

src/Ai/Base/Util/GenericBuffUtils.h

@@ -0,0 +1,68 @@
+/*
+ * Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it
+ * and/or modify it under version 3 of the License, or (at your option), any later version.
+ */
+
+#pragma once
+
+#include <string>
+#include <functional>
+#include "Common.h"
+#include "Group.h"
+#include "Chat.h"
+#include "Language.h"
+
+class Player;
+class PlayerbotAI;
+
+namespace ai::buff
+{
+
+// Build an aura qualifier "single + greater" to avoid double-buffing
+std::string MakeAuraQualifierForBuff(std::string const& name);
+
+// Returns the group spell name for a given single-target buff.
+// If no group equivalent exists, returns "".
+std::string GroupVariantFor(std::string const& name);
+
+// Checks if the bot has the required reagents to cast a spell (by its spellId).
+// Returns false if the spellId is invalid.
+bool HasRequiredReagents(Player* bot, uint32 spellId);
+
+// Applies the "switch to group buff" policy if: the bot is in a group of size x+,
+// the group variant is known/useful, and reagents are available. Otherwise, returns baseName.
+// If announceOnMissing == true and reagents are missing, calls the 'announce' callback
+// (if provided) to notify the party/raid.
+std::string UpgradeToGroupIfAppropriate(
+    Player* bot,
+    PlayerbotAI* botAI,
+    std::string const& baseName,
+    bool announceOnMissing = false,
+    std::function<void(std::string const&)> announce = {}
+    );
+}
+
+namespace ai::spell
+{
+    bool HasSpellOrCategoryCooldown(Player* bot, uint32 spellId);
+}
+
+namespace ai::chat {
+    inline std::function<void(std::string const&)> MakeGroupAnnouncer(Player* me)
+    {
+        return [me](std::string const& msg)
+        {
+            if (Group* g = me->GetGroup())
+            {
+                WorldPacket data;
+                ChatMsg type = g->isRaidGroup() ? CHAT_MSG_RAID : CHAT_MSG_PARTY;
+                ChatHandler::BuildChatPacket(data, type, LANG_UNIVERSAL, me, /*receiver=*/nullptr, msg.c_str());
+                g->BroadcastPacket(&data, true, -1, me->GetGUID());
+            }
+            else
+            {
+                me->Say(msg, LANG_UNIVERSAL);
+            }
+        };
+    }
+}

src/Ai/Class/Paladin/Action/PaladinActions.cpp

@@ -11,7 +11,7 @@
 #include "Playerbots.h"
 #include "SharedDefines.h"
 #include "../../../../../src/server/scripts/Spells/spell_generic.cpp"
-#include "GenericBuffUtils.h"
+#include "Ai/Base/Util/GenericBuffUtils.h"
 #include "Group.h"
 #include "ObjectAccessor.h"