veitR/mod-playerbots
1
0
Fork 0
mirror of https://github.com/liyunfan1223/mod-playerbots.git synced 2026-06-20 15:39:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core/Travel): LOS check before trusting raw cmangos waypoints

Browse Source
This commit is contained in:
bash 2026-05-14 21:56:54 +02:00
parent 76d776e572
commit 6a0dc3f2f6
1 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/Ai/Base/Actions/MovementActions.cpp
View File

@ -3234,14 +3234,29 @@ bool MovementAction::RefineWalkPoints(std::vector<G3D::Vector3>& walkPoints)
// active. When AC mmap can't validate the segment (empty // active. When AC mmap can't validate the segment (empty
// result, or IsPathCheating rejects a 2-point shortcut / // result, or IsPathCheating rejects a 2-point shortcut /
// steep hop), fall back to dispatching the raw (A, B) pair // steep hop), fall back to dispatching the raw (A, B) pair
// instead of aborting the plan. Common cases: cmangos // instead of aborting the plan — but only if vmap LOS is
// waypoints landing in 1y navmesh gaps from AC extractor // clear between A and B. Without LOS check, "trust raw"
// differences, tile-edge artifacts at zone borders. // tunnels through visual-only obstacles (trees, models) that
bool const trustRaw = segPath.empty() || // aren't in the navmesh.
bool const mmapFail = segPath.empty() ||
TravelPath::IsPathCheating(segPath, aPos.distance(bPos)); TravelPath::IsPathCheating(segPath, aPos.distance(bPos));
if (trustRaw) if (mmapFail)
{ {
Map* m = bot->GetMap();
bool const inLos = m && m->isInLineOfSight(
a.x, a.y, a.z + 1.0f,
b.x, b.y, b.z + 1.0f,
bot->GetPhaseMask(), LINEOFSIGHT_ALL_CHECKS, VMAP::ModelIgnoreFlags::Nothing);
if (!inLos)
{
// Visual obstacle between A and B — don't tunnel.
// Abort the plan so MoveFarTo can re-derive a route
// that mmap can verify.
return false;
}
if (i == 0) if (i == 0)
refined.emplace_back(a); refined.emplace_back(a);
refined.emplace_back(b); refined.emplace_back(b);