From 565b853f53afba1085edfccf0f2f2650463cefdd Mon Sep 17 00:00:00 2001 From: bash Date: Sun, 10 May 2026 20:20:07 +0200 Subject: [PATCH] refactor(Core/Travel): Drop redundant NAV_GROUND_STEEP excludes (core handles via IsBot) --- src/Ai/Base/Actions/BattleGroundTactics.cpp | 1 - src/Ai/Base/Actions/GoAction.cpp | 1 - src/Ai/Base/Actions/MovementActions.cpp | 2 -- src/Mgr/Travel/TravelMgr.cpp | 2 -- src/Mgr/Travel/TravelNode.cpp | 1 - 5 files changed, 7 deletions(-) diff --git a/src/Ai/Base/Actions/BattleGroundTactics.cpp b/src/Ai/Base/Actions/BattleGroundTactics.cpp index 5c96967c4..efb2fce7f 100644 --- a/src/Ai/Base/Actions/BattleGroundTactics.cpp +++ b/src/Ai/Base/Actions/BattleGroundTactics.cpp @@ -4292,7 +4292,6 @@ bool ArenaTactics::Execute(Event /*event*/) if (losBlocked) { PathGenerator path(bot); - path.AddExcludeFlag(NAV_GROUND_STEEP); path.CalculatePath(target->GetPositionX(), target->GetPositionY(), target->GetPositionZ(), false); if (path.GetPathType() != PATHFIND_NOPATH) diff --git a/src/Ai/Base/Actions/GoAction.cpp b/src/Ai/Base/Actions/GoAction.cpp index d428f336f..61a7550c2 100644 --- a/src/Ai/Base/Actions/GoAction.cpp +++ b/src/Ai/Base/Actions/GoAction.cpp @@ -124,7 +124,6 @@ bool GoAction::Execute(Event event) if (botAI->HasStrategy("debug move", BOT_STATE_NON_COMBAT)) { PathGenerator path(bot); - path.AddExcludeFlag(NAV_GROUND_STEEP); path.CalculatePath(x, y, z, false); diff --git a/src/Ai/Base/Actions/MovementActions.cpp b/src/Ai/Base/Actions/MovementActions.cpp index ccfd27a17..6fae3d3f4 100644 --- a/src/Ai/Base/Actions/MovementActions.cpp +++ b/src/Ai/Base/Actions/MovementActions.cpp @@ -977,7 +977,6 @@ bool MovementAction::ReachCombatTo(Unit* target, float distance) return false; PathGenerator path(bot); - path.AddExcludeFlag(NAV_GROUND_STEEP); path.CalculatePath(tx, ty, tz, false); PathType type = path.GetPathType(); int typeOk = PATHFIND_NORMAL | PATHFIND_INCOMPLETE | PATHFIND_SHORTCUT; @@ -1885,7 +1884,6 @@ PathResult MovementAction::GeneratePath(float x, float y, float z, uint32 accept { PathResult result; PathGenerator gen(bot); - gen.AddExcludeFlag(NAV_GROUND_STEEP); gen.CalculatePath(x, y, z, forceDestination); result.pathType = gen.GetPathType(); result.reachable = !(result.pathType & (~acceptMask)); diff --git a/src/Mgr/Travel/TravelMgr.cpp b/src/Mgr/Travel/TravelMgr.cpp index ded52bbcf..7d287e824 100644 --- a/src/Mgr/Travel/TravelMgr.cpp +++ b/src/Mgr/Travel/TravelMgr.cpp @@ -719,7 +719,6 @@ std::vector WorldPosition::getPathStepFrom(WorldPosition startPos } PathGenerator path(pathUnit); - path.AddExcludeFlag(NAV_GROUND_STEEP); auto result = getPathStepFrom(startPos, path); if (tempCreature) @@ -852,7 +851,6 @@ std::vector WorldPosition::getPathFromPath(std::vectorGetMapId()) { PathGenerator path(bot); - path.AddExcludeFlag(NAV_GROUND_STEEP); path.CalculatePath(startNodePosition.GetPositionX(), startNodePosition.GetPositionY(), startNodePosition.GetPositionZ()); PathType type = path.GetPathType(); bool reachable = !(type & ~(PATHFIND_NORMAL | PATHFIND_INCOMPLETE | PATHFIND_FARFROMPOLY));