veitR/mod-playerbots
1
0
Fork 0
mirror of https://github.com/liyunfan1223/mod-playerbots.git synced 2026-02-20 18:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update ChatHelper.cpp, Replace sprintf with snprintf (#1278)

Browse Source 
Use snprintf instead of sprintf for item color formatting to prevent buffer overflows and to silence warnings in macOS versions.
This commit is contained in:
Not 2025-05-09 10:01:21 -04:00 committed by GitHub
parent 9ca326c8cb
commit 43b0852438
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ChatHelper.cpp
View File

@ -382,7 +382,7 @@ std::string const ChatHelper::FormatSpell(SpellInfo const* spellInfo)
std::string const ChatHelper::FormatItem(ItemTemplate const* proto, uint32 count, uint32 total) std::string const ChatHelper::FormatItem(ItemTemplate const* proto, uint32 count, uint32 total)
{ {
char color[32]; char color[32];
sprintf(color, "%x", ItemQualityColors[proto->Quality]); snprintf(color, sizeof(color), "%x", ItemQualityColors[proto->Quality]);
std::string itemName; std::string itemName;
const ItemLocale* locale = sObjectMgr->GetItemLocale(proto->ItemId); const ItemLocale* locale = sObjectMgr->GetItemLocale(proto->ItemId);
@ -409,7 +409,7 @@ std::string const ChatHelper::FormatItem(ItemTemplate const* proto, uint32 count
std::string const ChatHelper::FormatQItem(uint32 itemId) std::string const ChatHelper::FormatQItem(uint32 itemId)
{ {
char color[32]; char color[32];
sprintf(color, "%x", ItemQualityColors[0]); snprintf(color, sizeof(color), "%x", ItemQualityColors[0]);
std::ostringstream out; std::ostringstream out;
out << "|c" << color << "|Hitem:" << itemId << ":0:0:0:0:0:0:0" out << "|c" << color << "|Hitem:" << itemId << ":0:0:0:0:0:0:0"