veitR/mod-playerbots
1
0
Fork 0
mirror of https://github.com/liyunfan1223/mod-playerbots.git synced 2026-02-20 18:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Prevents bots from learning spells twice (#1211)

Browse Source 
* Fix: Prevents bots from learning spells twice

Added bot->HasSpell() check before calling bot->learnSpell() to ensure the bot does not learn spells it already has.

This avoids redundant behavior, possible unnecessary logging, and inconsistencies in learning spells trained with SPELL_EFFECT_LEARN_SPELL.

* Possible fix
This commit is contained in:
EricksOliveira 2025-04-18 18:04:35 -03:00 committed by GitHub
parent 7737f9ab72
commit 27e3b802b7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/strategy/actions/TrainerAction.cpp
View File

@ -33,13 +33,18 @@ void TrainerAction::Learn(uint32 cost, TrainerSpell const* tSpell, std::ostrings
if (spellInfo->Effects[j].Effect == SPELL_EFFECT_LEARN_SPELL) if (spellInfo->Effects[j].Effect == SPELL_EFFECT_LEARN_SPELL)
{ {
uint32 learnedSpell = spellInfo->Effects[j].TriggerSpell; uint32 learnedSpell = spellInfo->Effects[j].TriggerSpell;
if (!bot->HasSpell(learnedSpell))
{
bot->learnSpell(learnedSpell); bot->learnSpell(learnedSpell);
learned = true; learned = true;
} }
} }
}
if (!learned) if (!learned && !bot->HasSpell(tSpell->spell))
{
bot->learnSpell(tSpell->spell); bot->learnSpell(tSpell->spell);
}
msg << " - learned"; msg << " - learned";
} }