veitR/mod-playerbots
1
0
Fork 0
mirror of https://github.com/liyunfan1223/mod-playerbots.git synced 2026-02-20 18:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Resolved crash in BGStatusAction (#1656)

Browse Source 
* Prevent race condition and server crash

* Updated other direct packet handling lines to queue packets instead
This commit is contained in:
avirar 2025-09-28 08:01:24 +10:00 committed by GitHub
parent 05d3a44481
commit 23d9931f65
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/strategy/actions/BattleGroundJoinAction.cpp
View File

@ -688,7 +688,7 @@ bool BGLeaveAction::Execute(Event event)
WorldPacket packet(CMSG_BATTLEFIELD_PORT, 20); WorldPacket packet(CMSG_BATTLEFIELD_PORT, 20);
packet << type << unk2 << (uint32)_bgTypeId << unk << uint8(0); packet << type << unk2 << (uint32)_bgTypeId << unk << uint8(0);
bot->GetSession()->HandleBattleFieldPortOpcode(packet); bot->GetSession()->QueuePacket(new WorldPacket(packet));
if (IsRandomBot) if (IsRandomBot)
botAI->SetMaster(nullptr); botAI->SetMaster(nullptr);
@ -917,7 +917,7 @@ bool BGStatusAction::Execute(Event event)
WorldPacket packet(CMSG_BATTLEFIELD_PORT, 20); WorldPacket packet(CMSG_BATTLEFIELD_PORT, 20);
packet << type << unk2 << (uint32)_bgTypeId << unk << action; packet << type << unk2 << (uint32)_bgTypeId << unk << action;
bot->GetSession()->HandleBattleFieldPortOpcode(packet); bot->GetSession()->QueuePacket(new WorldPacket(packet));
botAI->ResetStrategies(false); botAI->ResetStrategies(false);
if (!bot->GetBattleground()) if (!bot->GetBattleground())
@ -972,7 +972,7 @@ bool BGStatusAction::Execute(Event event)
WorldPacket packet(CMSG_BATTLEFIELD_PORT, 20); WorldPacket packet(CMSG_BATTLEFIELD_PORT, 20);
action = 0; action = 0;
packet << type << unk2 << (uint32)_bgTypeId << unk << action; packet << type << unk2 << (uint32)_bgTypeId << unk << action;
bot->GetSession()->HandleBattleFieldPortOpcode(packet); bot->GetSession()->QueuePacket(new WorldPacket(packet));
botAI->ResetStrategies(!IsRandomBot); botAI->ResetStrategies(!IsRandomBot);
botAI->GetAiObjectContext()->GetValue<uint32>("bg type")->Set(0); botAI->GetAiObjectContext()->GetValue<uint32>("bg type")->Set(0);
@ -1039,7 +1039,7 @@ bool BGStatusAction::Execute(Event event)
WorldPacket packet(CMSG_BATTLEFIELD_PORT, 20); WorldPacket packet(CMSG_BATTLEFIELD_PORT, 20);
packet << type << unk2 << (uint32)_bgTypeId << unk << action; packet << type << unk2 << (uint32)_bgTypeId << unk << action;
bot->GetSession()->HandleBattleFieldPortOpcode(packet); bot->GetSession()->QueuePacket(new WorldPacket(packet));
botAI->ResetStrategies(false); botAI->ResetStrategies(false);
if (!bot->GetBattleground()) if (!bot->GetBattleground())